Branch: refs/heads/fix-2098-on-windows
Home: https://github.com/pyinstaller/pyinstaller
Commit: d5c56699f4f4cb3dab873b484383f874028d1e18
https://github.com/pyinstaller/pyinstaller/commit/d5c56699f4f4cb3dab873b484383f874028d1e18
Author: Bryan A. Jones <[email protected]>
Date: 2016-07-24 (Sun, 24 Jul 2016)
Changed paths:
M tests/functional/scripts/pyi_multiprocess.py
Log Message:
-----------
Fix: Correct usage of multiprocessing test.
Fixes:
- In general, the superclass' constructor should be invoked first, unless
there's a compelling reason not to do so.
- More descriptive diagnostic messages were added.
- Following the example of
https://docs.python.org/2/library/multiprocessing.html#the-process-class, the
processes are join()ed.
- Items put into the Queue are now removed. Quoting the programming guidelines
at
https://docs.python.org/2/library/multiprocessing.html#programming-guidelines:
Joining processes that use queues
Bear in mind that a process that has put items in a queue will wait before
terminating until all the buffered items are fed by the “feeder” thread to the
underlying pipe. (The child process can call the cancel_join_thread() method of
the queue to avoid this behaviour.)
This means that whenever you use a queue you need to make sure that all items
which have been put on the queue will eventually be removed before the process
is joined. Otherwise you cannot be sure that processes which have put items on
the queue will terminate. Remember also that non-daemonic processes will be
joined automatically.
Commit: 5a43ca8c1756b6400fcffc66fe35bb79a2db4644
https://github.com/pyinstaller/pyinstaller/commit/5a43ca8c1756b6400fcffc66fe35bb79a2db4644
Author: Bryan A. Jones <[email protected]>
Date: 2016-07-24 (Sun, 24 Jul 2016)
Changed paths:
M tests/functional/test_basic.py
Log Message:
-----------
Fix: Skip failing test (see issue #2116).
Compare:
https://github.com/pyinstaller/pyinstaller/compare/1ec2473a1168...5a43ca8c1756
--
You received this message because you are subscribed to the Google Groups
"PyInstaller" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/pyinstaller.
For more options, visit https://groups.google.com/d/optout.
