On Tue, Nov 29, 2011 at 6:50 AM, Kees Bos <[email protected]> wrote: > On Tue, 2011-11-29 at 03:37 +0100, Lukasz Mach wrote: >> Hi, >> >> I made my first pyjamas widget, based on DateField (attached), for >> selecting month instead of full date. >> >> All PyJS guru - please look at it, and tell me: >> - what did I do wrong/against pyj(ama)s philosophy there, >> - what to do with it? should such widget go into pyj(ama)s code,
yes. please either send me an ssh public key and a sourceforge username, or submit a patch at the usual place, http://code.google.com/p/pyjamas/issues either way, you should: * add yourself to the copyright file * add Copyright (C) 2011 you to the file * add a short description to the changelog this will save someone else from having to do that on your behalf. also unless we split the entire file down into smaller things (which i can't think of a good reason to do right now) it's probably best to have the month picker as part of the standard file, not in a separate one. >> > > Looks good to me. The only drawback I see, is that every string lookup > now requires a function call. This is an performance penalty, which > could be overcome by optionally translate _("foo") to "foo". >

