On Tue, Nov 29, 2011 at 1:35 PM, Lukasz Mach <[email protected]> wrote: > (29.11.2011 12:23), Luke Kenneth Casson Leighton wrote: >> On Tue, Nov 29, 2011 at 6:50 AM, Kees Bos<[email protected]> wrote: >>> On Tue, 2011-11-29 at 03:37 +0100, Lukasz Mach wrote: >>>> Hi, >>>> >>>> I made my first pyjamas widget, based on DateField (attached), for >>>> selecting month instead of full date. >>>> >>>> All PyJS guru - please look at it, and tell me: >>>> - what did I do wrong/against pyj(ama)s philosophy there, >>>> - what to do with it? should such widget go into pyj(ama)s code, >> yes. please either send me an ssh public key and a sourceforge >> username, or submit a patch at the usual place, >> http://code.google.com/p/pyjamas/issues > > Ok, I will try to remind my SF user, and I will send you ssh public key. > However, I'm curious, if pyjamas is on git, why you're giving access to > repo to everyone who want?
so that there's no need for "maintainers" to do the work that you could easily do yourself. > Isn't it better/safer/easier if contributors do "fork" of repo eg. on > github, and you pull/merge their changes to your repo? that involves me (or someone else) "doing work". i'd much rather trust people not to screw up, it wakes them up and they pay attention to what they're doing :) >> either way, you should: >> >> * add yourself to the copyright file >> * add Copyright (C) 2011 you to the file >> * add a short description to the changelog >> >> this will save someone else from having to do that on your behalf. >> >> also unless we split the entire file down into smaller things (which >> i can't think of a good reason to do right now) it's probably best to >> have the month picker as part of the standard file, not in a separate >> one. > > Ok. Good point. > > But when it goes to pyjamas, then I think we should agree something > about locales. Should it be in examples/libtest/I18N way, or in > "gettext" way? Or there should be no locales? Or nobody care about it? nobody cares about it :) ok, more to the point: if you're going to "care", it has to be taken care of (starting with one small example and going from there) consistently, across everything. i think, however... there actually isn't anything that requires any text, other than the date/time picker! which is bizarre. btw, rather than that exception thing, i'd prefer you created a dummy "locales" module in pyjs/src/pyjs/lib/locales.py then you can always do "import locales". l.

