On Thu, Dec 22, 2011 at 7:46 AM, Anthon van der Neut <[email protected]> wrote:
> I will look into the git format-patch stuff. I must confess I pulled the
> repository using mercurial :-[ . I will pull the tree using git and
> put the changes in there from the mercurial repository and assume I can then
> manage to figure out git format-patch.
>
> One clarification up front would be helpful.
>
>
> On 2011-12-22 06:20, lkcl luke wrote:
>
> On Wed, Dec 21, 2011 at 6:24 PM, Anthon van der Neut <[email protected]> wrote:
>
> <snip>
>
> - where should the stringformat.py file best go (it is currently next to
>
> pyjslib.py)
>
>  hmmm i would say somewhere in pyjslib.py ... hrmmm... ok, yep,
> pyjslib.py for now but put a comment at the start and end saying "this
> code came from pypy from this point onwards...."
>
> I hope it is clear I have it as a seperate file right now. I import that
> file in the CPython unittest program, more easily than if the whole thing is
> incorporated in pyjslib.py.
> As the last line of pyjslib.py I have now:
>    from stringformat import string_format

 yes.

> pyjs does find and compile it without a problem. So what would be the
> advantage of incorporating this in pyjslib.py? (execution speed?)

 it's not that, it's other uses such as pyjscompile, pyjampiler etc.
pyjampiler needs two files.  sys.py and pyjslib.py.  everything
required to get a working runtime system is within those two files.

 if there's an exception to splitting that file, i'd far rather it was
done properly - namely that it was tidied up.  in _that_ case, having
stringformat.py not associated with the string class would be an
additional inconvenience when the time came to it.

 l.

Reply via email to