On Mon, Dec 26, 2011 at 2:35 PM, Anthon van der Neut <[email protected]> wrote:
> I now also implemented the builtin format(val, spec), which was easy,

 good stuff!

> But it took a bit to find out why format was not found. I had to add it to
> pyjs/src/pyjs/translator_proto.py, but I was distracted by
> pyjs/src/pyjs/translator_dict.py. for a while and that is not used .....
>
> So now
>   print '{1}(0}'.format(2, 4)
> and
>   print format(66, 'x')
> both print: 42
>
> There are additional testcases in BuildinTest.py, and a few that I have
> to check (some might be Cpython-isms) and are currently commented out.
> There are 645 tests passed now in BuiltinTest, and I hope someone can
> review this to see if there are no major issues. If not format can,
> IMHO, be removed from the BUILTINS.TODO list.

 ok, it can only be removed when the tests that are commented out are
put back in.

 the idea is to have the tests actually fail if, in fact, they fail.

 this indicates to people that there is still work to be done.

 if on the other hand the tests are removed, then that is basically
lying to people that things are all "ok" and we can't do that :)

 l.

Reply via email to