On Wed, 28 Dec 2011 05:00:16 +0000, lkcl luke <luke.leighton-AT-gmail.com> wrote:
> On Tue, Dec 27, 2011 at 7:14 PM, <[email protected]> wrote: > > On Tue, 27 Dec 2011 17:53:52 +0000, lkcl luke <luke.leighton-AT-gmail.com> > > wrote: > > > >> On Tue, Dec 27, 2011 at 5:27 PM, <[email protected]> wrote: > >> > I have posted a comment on Issue 537 which raised this problem almost a > >> > year ago but never produced any clear resolution. The link is: > >> > > >> > http://code.google.com/p/pyjamas/issues/detail?id=537&start=100 > >> > > >> > My conclusion, of course based only on my own applications, is that > >> > setFocus would work properly in Chrome/Safari if we just threw this > >> > override away. Since it's easy to check, it would be nice if people > >> > would try that on their bleeding edge applications. Or perhaps somebody > >> > actually knows of a good reason why there needs to be an override and > >> > can make it work correctly. > >> > >> phil, > >> > >> if you check GWT's latest code, it's best to always follow that. > >> i've seen circumstances where not having the override did some pretty > >> strange things. > >> > >> l. > > > > Luke, > > I have checked out the gwt code and it appears to me that that Safari > > override code has been commented out. I have posted the details in a > > further comment on Issue 537. I think I found the right place in gwt but I > > am not at all familiar with the way it is organised, so it would be helpful > > if someone who is more au fait with it would check my conclusion. > > if it looks the same, it is the same. (actually, manual translation > between python and java really isn't hard). > > you saw the words > ImplSafarisomethingsomethingFocussomethingsomething, right? that's > the equivalent of platform-override. > > and the code was somewhere in a path with the words com google client > com user com google user rubbish shit directory structure client ui > right? > > l. Luke, I have posted a more detailed description of what I have found in GWT as a further comment on Issue 537, with copies of the relevant files. I ask a question there about how to interpret code that appears to be commented out, i.e. is it really commented out or is it to be taken as literal Javascript? If, as I suspect, the second of those alternatives is correct, to be compatible with the GWT code, the safari override for Focus.py needs to have createFocusable() removed and the blur and focus functions need to act on the element, not on its first child. I have incorporated both those modification in my local copy of the code and my test application now throws no Javascript errors and operates correctly. If we can agree on the modifications needed, I will provide a diff. Phil
