On Sat, Feb 25, 2012 at 10:36 AM, Pascal Chambon <[email protected]> wrote:
> Le 25/02/2012 11:09, lkcl luke a écrit :
>> On Sat, Feb 25, 2012 at 10:01 AM, Pascal Chambon<[email protected]> wrote:
>>
>>>> so - someone needs to stop this from happening! reading the history
>>>> token and not calling the history change if it's not needed would do
>>>> the trick.
>>>>
>>>> l.
>>> I'll look at it asap.
>> *thumbs-up* pascal. it's only a couple of lines of code.
>>
>> l.
> I pushed a fix checking the current history token before pushing a new
> one, but I couldn't actually reproduce the bug - in browser mode,
> History.newItem(new_token) doesn't trigger onHistoryChanged if the new
> token is the same as the old one (which sounds sensible).
> So I guess it'd rather be a feature lacking in pyjd (I haven't tested,
> since I don't have the required steup to run the site in pyjd mode, with
> local browser etc.)?
if (token != $wnd.__historyToken) {
$wnd.__historyToken = token;
// TODO - move init back into History
// this.onHistoryChanged(token);
@{{onHistoryChanged}}(token);
}
ah. yes.
