Weeeell, now I'm a little confused:

http://code.google.com/p/pyjamas/issues/attachmentText?id=706&aid=7060003000&name=logging.diff

a) We already _had_ a logging module mimicking CPython's logging
module before I made one!

~/Development/pyjamas$ find . -name logging
./library/pyjamas/logging
./pyjs/src/pyjs/lib/logging

  -> library/pyjamas/logging is what I made. What it does to mimick
CPython logging is: (see top of library/pyjamas/logging/__init__.py)

# blatantly copy everything from CPython's logging
from logging import *

  -> pyjs/src/pyjs/lib/logging is obviously from Kees. The git log on
handlers.py says:

~/Development/pyjamas/pyjs/src/pyjs/lib/logging$ git log handlers.py
commit d79d139433f54cf89dc8eb3a29dbae1fc731c6f6
Author: keesbos <keesbos@7a2bd370-bda8-463c-979e-2900ccfb811e>
Date:   Thu Dec 3 10:54:27 2009 +0000

    Add initial port of python logging module

    git-svn-id:
https://pyjamas.svn.sourceforge.net/svnroot/pyjamas/trunk@2347
7a2bd370-bda8-463c-979e-2900ccfb811e

The code base is slightly larger than mine, because the
re-implementation is actually writing the code again. (This is what I
tried too do before I had the flash of genius with the above import
statement! :-) )

Is the re-implementation necessary, because Pythons logging module is
not pure Python or so?


b) library/pyjamas/log.py (this is where the logging module is used
and where the error comes from) imports the logging module as follows:

  from pyjamas import logging

Can it be that this takes mine in pyjd and Kees' in pyjs?

Peter


2012/3/30 Phil Charlesworth <[email protected]>:
> On 28/03/12 23:11, Peter Bittner wrote:
>> 2012/3/28 Phil Charlesworth<[email protected]>:
>>
>>> I have added Issue #706 to the Bug List.
>>> http://code.google.com/p/pyjamas/issues/detail?id=706
>>>
>> That's the weired JavaScript Error I'm after. I bet logging works fine
>> with Pyjamas Desktop.
>>
>> I'm currently trying to free time to work on this issue this week late at 
>> night.
>>
>> Peter
>>
> I have attached a comment to Issue  #706 with an analysis of why it's
> failing and a suggestion for a possible solution (with diff).
>
> Phil

Reply via email to