On Wed, Jul 25, 2012 at 6:03 PM, Łukasz Mach <lukasz.m...@pagema.net> wrote: > > Now I know it also :). DisclosurePanel uses getImageBaseURL to get base url > of .js file.
nice work :-) > So, I modified Calendar.py to include icon-calendar.gif by default - here is > commit: > https://github.com/mahomahomaho/pyjs/commit/64299dbb4558fbd8d3b2772108675af9da70e2a3 > . > > I didn't do pull request about it, because there is already pending pull > request from this repo, so I'm not able to do it. i've updated your issue/pull -- you can only do one pull request per branch. in general, you should always submit a request from a branch, NOT master, for this exact reason -- you can keep working easily. > However - i'm not 100% sure if my changes are ok. I don't know if they will > work well with pyjd - I can't check because I still couldn't build pyjd with > my ubuntu 12.04 (well, I didn't try very hard). it'll work fine -- pyjs uses `pygwt.browser.py`, other runtimes use `pygwt.py`. just cleanup per my comments and we'll merge no prob. -- C Anthony --
