On Nov 9, 2007, at 1:46 PM, Ben Bangert wrote:

> I've re-factored the error handling in pylons-dev to now use  
> WebError, as well as cleaning up the WebError package a little bit  
> and reducing a lot of the visual clutter that was present in the  
> default pages.
>
> I'm now actually happy enough with the appearance of exceptions in  
> the default template in WebError, that I have no desire to further  
> skin it for Pylons as well. Note that the XML view of the traceback  
> isn't ready yet, should you give it a go.
>
> I'm curious if anyone has any feedback, or suggestions for anything  
> else to include on the exception traceback page.
>

Awesome. Like I mentioned to you on AIM, I sort of miss some of the  
color of the original Pylons skin, but that's not a big deal.

The Extra data section currently spits out 3 sections (they all have  
an 'Extra Data' header which is kinda superfluous), though one of  
them is blank. I see there's a hook to get the config dictionary  
displayed like it was before via environ['weberror.config']. When I  
manually added that to environ it showed up fine (so Pylons needs to  
do this somewhere), but there were now 4 sections, one of them still  
blank).

Also, the Registry restorer stuff looks for EvalException under the  
key 'paste.evalexception' under environ, to know whether or not it  
should enable itself when there's an exception. The registry  
continues to work work in Pylons apps because RegistryManager is  
outside of EvalException, but restoration breaks if its inside of it  
(there's tests for this in Paste).

We can probably get away with renaming the keys if we also maintain  
the old ones, but get_debug_count might be a little odd to deal with.  
Keeping the old key names would be easiest fix, unfortunately

--
Philip Jenvey



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"pylons-devel" group.
To post to this group, send email to pylons-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/pylons-devel?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to