On Tue, 27 Oct 2009, Manolo Padron Martinez wrote:

I'm trying to compile JCC and I think I found a bug in setup.py on
line 115 it checks with_setuptools againts '0.6c7'. I have '0.6c11' so
always fails (and It should not).

Indeed, the version checking code in there is bogus.
But that version is also unexpected.
I didn't know that 0.6c11 had come out at all !
Thanks for letting me know.

The attached patch resolves the bad version checking code.
Could you please apply it to jcc's setup.py and let me know if it solves your problem ? In particular, as this is a new, unknown, version of setuptools, I'd be interested to know if it works for you.
I did a test build on Mac OS X 10.6 with it and all seemed correct.

Since you didn't tell me your OS, your JCC version or anything else, I have to assume - arbitrarily - that you're on Linux with the latest JCC.

Thanks, and regards from San Francisco !

Andi..
Index: setup.py
===================================================================
--- setup.py    (revision 829919)
+++ setup.py    (working copy)
@@ -109,10 +109,11 @@
         raise ImportError
     from setuptools import setup, Extension
     from pkg_resources import require
-    with_setuptools = require('setuptools')[0].version
-
+    with_setuptools = require('setuptools')[0].parsed_version
+    
     enable_shared = False
-    if with_setuptools >= '0.6c7' and 'NO_SHARED' not in os.environ:
+    with_setuptools_min = ('00000000', '00000006', '*c', '00000007', '*final')
+    if with_setuptools >= with_setuptools_min and 'NO_SHARED' not in 
os.environ:
         if platform in ('darwin', 'ipod', 'win32'):
             enable_shared = True
         elif platform == 'linux2':

Reply via email to