Hi Andi, On Sun, Oct 7, 2012 at 9:08 PM, Andi Vajda <va...@apache.org> wrote: > > Hi Caleb, > > On Tue, 2 Oct 2012, Caleb Burns wrote: > > I took a look at your patch. A couple of questions: > > - In jcc/helpers/linux.py, you seem to be getting rid of the 0.6.15 > setuptools case. How is that version handled now ? > I remember adding this case last May since it's a version out there in the > wild and patching it failed as it needs the 0.6c7 patch. > Am I reading this correctly that you're assuming 0.6.15 to be compatible > with 0.6.1 distribute ?
The 0.6.15 setuptools (specifically 0.6.15-1ubuntu1) was the version installed by Ubuntu which installs distribute-0.6.15. I changed the 0.6.15 down to 0.6.1 because I tested distribute-0.6.1, 0.6.15, 0.6.28 and they all worked with JCC when applying the 0.6c7 patch. > - You have a line of new code in linux.py that says: > + if build_ext.use_stubs or os.name == 'nt': > How can os.name be 'nt' when linux.py is being run ? The `os.name == 'nt'` line was an oversight. I copied the relevant code from setuptools that the 0.6c7 and 11 patches touched, merged the patches, and incorporated the new code into jcc/helpers/linux.py. That line should just be: + if build_ext.use_stubs: Caleb Burns
