Dnia 2016-07-02 03:37 Andreas Kloeckner napisał(a): >Tomasz Rybak <tomasz.ry...@post.pl> writes: > >> Hello. >> When building Debian packages, I noticed few issues. Those are not even >> problems >> (they do not prevent building) but some tools complain about them. >> >> 1. examples/download-examples-from-wiki.py >> It has #! only as third line - first two are "from __future__ import ...". >> Can you fix that? > >Done. > >> 2. pyopencl/scan.py contains copyright pointing to Thrust at >> code.google.com. >> While URL still contains source code, it is now archival - i.e. it has old >> release, etc. >> Would it be better to point to Thrust at GitHub: >> https://github.com/thrust/thrust >> (similarly for PyCUDA) > >Done. (for both)
Thanks. > >> 3. NDArray (from compyte) has some non-Python3 code: >> byte-compiling >> /home/admin/A/pyopencl-2016.1/debian/tmp/usr/lib/python3/dist-packages/pyope >> ncl/compyte/ndarray/test_gpu_ndarray.py to test_gpu_ndarray.cpython-35.pyc >> File >> "usr/lib/python3/dist-packages/pyopencl/compyte/ndarray/test_gpu_ndarray.py", >> line 314 >> print shp, dtype, offseted, order1, order2 >> ^ >> SyntaxError: Missing parentheses in call to 'print' >> >> byte-compiling >> /home/admin/A/pyopencl-2016.1/debian/tmp/usr/lib/python3/dist-packages/pyope >> ncl/compyte/ndarray/gen_elemwise.py to gen_elemwise.cpython-35.pyc >> File >> "usr/lib/python3/dist-packages/pyopencl/compyte/ndarray/gen_elemwise.py", >> line 955 >> print sio.getvalue() >> ^ >> SyntaxError: invalid syntax >> >> Again - nothing critical (only test and dead-function code), but prevents >> pre-compiling Python3 code. > >That's not my code (I don't use it, and I didn't write it) and so I'm >reluctant to touch it. > OK, not a problem. BTW - now doc/Makefile uses python3 to call Sphinx, but python (usually Python2) to build constants (in "constants" Make target). Should it be unified/fixed? Best regards. Tomasz Rybak _______________________________________________ PyOpenCL mailing list PyOpenCL@tiker.net https://lists.tiker.net/listinfo/pyopencl
