Author: Maciej Fijalkowski <[email protected]>
Branch: lightweight-finalizers
Changeset: r47883:66cdca63f106
Date: 2011-10-09 01:25 +0200
http://bitbucket.org/pypy/pypy/changeset/66cdca63f106/
Log: leave a comment how this is buggy
diff --git a/pypy/rlib/rmmap.py b/pypy/rlib/rmmap.py
--- a/pypy/rlib/rmmap.py
+++ b/pypy/rlib/rmmap.py
@@ -292,6 +292,9 @@
elif _POSIX:
self.closed = True
if self.fd != -1:
+ # XXX this is buggy - raising in an RPython del is not a good
+ # idea, we should swallow the exception or ignore the
+ # underlaying close error code
os.close(self.fd)
self.fd = -1
if self.size > 0:
_______________________________________________
pypy-commit mailing list
[email protected]
http://mail.python.org/mailman/listinfo/pypy-commit
