Author: Armin Rigo <[email protected]>
Branch: concurrent-marksweep
Changeset: r47977:7e06efc4ec2c
Date: 2011-10-12 19:56 +0200
http://bitbucket.org/pypy/pypy/changeset/7e06efc4ec2c/
Log: Comment. A test in test_newgc sometimes fails, because of this.
diff --git a/pypy/rpython/memory/gc/concurrentms.py
b/pypy/rpython/memory/gc/concurrentms.py
--- a/pypy/rpython/memory/gc/concurrentms.py
+++ b/pypy/rpython/memory/gc/concurrentms.py
@@ -966,6 +966,10 @@
# the location contains really an object, which is marked.
# check the typeid to see if it's a weakref. XXX could
# be faster
+ # XXX actually it's very wrong: if we read a weakref out
+ # of an object during collection_running==1, or during
+ # collection_running==2 but before we reach that point,
+ # the target object will never be marked
tid = hdr.tid
type_id = llop.extract_high_ushort(llgroup.HALFWORD, tid)
wroffset = self.weakpointer_offset(type_id)
_______________________________________________
pypy-commit mailing list
[email protected]
http://mail.python.org/mailman/listinfo/pypy-commit
