Author: Alex Gaynor <alex.gay...@gmail.com> Branch: numpy-full-fromstring Changeset: r50506:44e16832a75d Date: 2011-12-14 11:26 -0500 http://bitbucket.org/pypy/pypy/changeset/44e16832a75d/
Log: Added some review notes. diff --git a/pypy/module/micronumpy/REVIEW b/pypy/module/micronumpy/REVIEW new file mode 100644 --- /dev/null +++ b/pypy/module/micronumpy/REVIEW @@ -0,0 +1,14 @@ +Review items +============ + +* Rather than `True if len(sep_stripped) == 0 else False` just use: + `len(sep_stripped) == 0`. +* Rather than name the variable `A`, name it `items` or somsething like that. +* Rather than using `ptr`, use `idx`, since it's not really a pointer. +* Rather than doing a string format to raise an error (L67), use + `operationerrfmt`. +* Same comment about comparing array equality as before. +* No need for the `self.char == "?"` default. +* Rather than name the attribute `char`, name it `format_code`. +* `default_fromstring` can do `self.box(-1.0)`, instead of the coerce thing. +* Tests for both bool and long dtypes with this. _______________________________________________ pypy-commit mailing list pypy-commit@python.org http://mail.python.org/mailman/listinfo/pypy-commit
