Author: Maciej Fijalkowski <[email protected]> Branch: numppy-flatitter Changeset: r51788:977157a7ea64 Date: 2012-01-26 13:46 +0200 http://bitbucket.org/pypy/pypy/changeset/977157a7ea64/
Log: review diff --git a/pypy/module/micronumpy/REVIEW b/pypy/module/micronumpy/REVIEW --- a/pypy/module/micronumpy/REVIEW +++ b/pypy/module/micronumpy/REVIEW @@ -1,3 +1,5 @@ +* this file should go away before asking for a review :) + * I think we should wait for indexing-by-arrays-2, since this would clean up the iterator interface @@ -7,3 +9,17 @@ duplication, since the indexing is getting slowly fairly complex. * iterating over a transposed array still fails. + +* next_skip_x is implemented badly. It still iterates over items (calls + next_skip n times) and is jit.unroll_safe. This means that the JIT will assume + skip is a constant and compile a linear trace unrolling all iterations. This + is *BAD*. Instead it would be something like: + + for arrays: + + res.offset = self.offset + skip + + for views something slightly more complex that does appropriate modulo. + + Note that next() has unroll_safe, because the loop only dependas on the + length of shape which is a constant for assembler. \ No newline at end of file _______________________________________________ pypy-commit mailing list [email protected] http://mail.python.org/mailman/listinfo/pypy-commit
