[pypy-commit] pypy default: these XXX/commented lines are valid tests now

[bdkearns]

Author: Brian Kearns <bdkea...@gmail.com>
Branch: 
Changeset: r60898:196680d468e4
Date: 2013-02-06 02:50 -0500
http://bitbucket.org/pypy/pypy/changeset/196680d468e4/

Log:    these XXX/commented lines are valid tests now

diff --git a/pypy/module/bz2/test/test_bz2_file.py 
b/pypy/module/bz2/test/test_bz2_file.py
--- a/pypy/module/bz2/test/test_bz2_file.py
+++ b/pypy/module/bz2/test/test_bz2_file.py
@@ -103,12 +103,12 @@
         # writeonly
         bz2f = BZ2File(self.temppath, mode='w')
         bz2f.close()
-        # since we use fclose() internally you can't close it twice
-        # bz2f.close()
+        bz2f.close()
 
         # readonly
         bz2f = BZ2File(self.temppath, mode='r')
         bz2f.close()
+        bz2f.close()
 
     def test_tell(self):
         from bz2 import BZ2File
@@ -240,8 +240,7 @@
         self.create_temp_file()
 
         bz2f = BZ2File(self.temppath)
-        # XXX
-        #raises(TypeError, bz2f.readline, None)
+        raises(TypeError, bz2f.readline, None)
         sio = StringIO(self.TEXT)
         for line in sio.readlines():
             line_read = bz2f.readline()
@@ -253,8 +252,7 @@
         self.create_temp_file()
 
         bz2f = BZ2File(self.temppath)
-        # XXX
-        # raises(TypeError, bz2f.read, None)
+        raises(TypeError, bz2f.read, None)
         text_read = bz2f.read()
         assert text_read == self.TEXT
         bz2f.close()
@@ -333,8 +331,7 @@
         self.create_temp_file()
 
         bz2f = BZ2File(self.temppath)
-        # XXX
-        #raises(TypeError, bz2f.readlines, None)
+        raises(TypeError, bz2f.readlines, None)
         sio = StringIO(self.TEXT)
         assert bz2f.readlines() == sio.readlines()
         bz2f.close()
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
http://mail.python.org/mailman/listinfo/pypy-commit