Author: Gregor Wegberg <[email protected]>
Branch: gc-incminimark-pinning
Changeset: r73723:88df0344d983
Date: 2014-09-26 15:07 +0200
http://bitbucket.org/pypy/pypy/changeset/88df0344d983/
Log: added XXX: incminimark may zero out much more of the nursery than
intended
diff --git a/rpython/memory/gc/incminimark.py b/rpython/memory/gc/incminimark.py
--- a/rpython/memory/gc/incminimark.py
+++ b/rpython/memory/gc/incminimark.py
@@ -1674,6 +1674,10 @@
if prev - self.nursery >= self.nursery_cleanup:
nursery_barriers.append(prev)
else:
+ # XXX: length should not be 'self.nursery_cleanup', but rather
+ # 'self.nursery_cleanup - (prev - self.nursery)'. Otherwise
+ # in case we end up in this branch we zero out much more space
+ # overall than in original incminimark.
llarena.arena_reset(prev, self.nursery_cleanup, 2)
nursery_barriers.append(prev + self.nursery_cleanup)
#
_______________________________________________
pypy-commit mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-commit
