Author: Armin Rigo <ar...@tunes.org>
Branch:
Changeset: r79059:8cc92a2a2f23
Date: 2015-08-19 16:44 +0200
http://bitbucket.org/pypy/pypy/changeset/8cc92a2a2f23/
Log: If translation ends up calling build_flow() on something that is a
built-in function, complain more clearly.
diff --git a/rpython/flowspace/objspace.py b/rpython/flowspace/objspace.py
--- a/rpython/flowspace/objspace.py
+++ b/rpython/flowspace/objspace.py
@@ -13,6 +13,11 @@
def _assert_rpythonic(func):
"""Raise ValueError if ``func`` is obviously not RPython"""
+ try:
+ func.func_code.co_cellvars
+ except AttributeError:
+ raise ValueError("%r is not RPython: it is likely an unexpected "
+ "built-in function or type" % (func,))
if func.func_doc and func.func_doc.lstrip().startswith('NOT_RPYTHON'):
raise ValueError("%r is tagged as NOT_RPYTHON" % (func,))
if func.func_code.co_cellvars:
diff --git a/rpython/flowspace/test/test_objspace.py
b/rpython/flowspace/test/test_objspace.py
--- a/rpython/flowspace/test/test_objspace.py
+++ b/rpython/flowspace/test/test_objspace.py
@@ -1363,6 +1363,15 @@
simplify_graph(graph)
assert self.all_operations(graph) == {'bool': 1, 'inplace_add': 1}
+ def test_unexpected_builtin_function(self):
+ import itertools
+ e = py.test.raises(ValueError, build_flow, itertools.permutations)
+ assert ' is not RPython:' in str(e.value)
+ e = py.test.raises(ValueError, build_flow, itertools.tee)
+ assert ' is not RPython:' in str(e.value)
+ e = py.test.raises(ValueError, build_flow, Exception.__init__)
+ assert ' is not RPython:' in str(e.value)
+
DATA = {'x': 5,
'y': 6}
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
https://mail.python.org/mailman/listinfo/pypy-commit
