Author: Matti Picus <[email protected]>
Branch: pyfile-tell
Changeset: r85198:b23ad2aee931
Date: 2016-06-16 23:33 +0300
http://bitbucket.org/pypy/pypy/changeset/b23ad2aee931/

Log:    document why the test fails, need to call flush_buffers in
        PyFile_AsFile

diff --git a/pypy/module/cpyext/test/test_pyfile.py 
b/pypy/module/cpyext/test/test_pyfile.py
--- a/pypy/module/cpyext/test/test_pyfile.py
+++ b/pypy/module/cpyext/test/test_pyfile.py
@@ -142,5 +142,9 @@
             t_py = fid.tell()
             assert t_py == 80
             t_c = module.get_c_tell(fid)
+        # XXX currently fails since rlib/streamio BufferingInputStream has 
+        #     an internal readahead buffer self.buf and its self.pos can be 
+        #     out of sync with the underlying c-level FILE * (it's not called
+        #     a BufferingInputStream for nothing)
         assert t_c == t_py
 
_______________________________________________
pypy-commit mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-commit

Reply via email to