Author: Ronan Lamy <ronan.l...@gmail.com>
Branch: py3.5
Changeset: r89036:5718b9a37d0d
Date: 2016-12-13 11:10 +0000
http://bitbucket.org/pypy/pypy/changeset/5718b9a37d0d/

Log:    Fix cpyext -A testing: negative exit codes can happen and should
        count as failures

diff --git a/pypy/tool/pytest/apptest.py b/pypy/tool/pytest/apptest.py
--- a/pypy/tool/pytest/apptest.py
+++ b/pypy/tool/pytest/apptest.py
@@ -182,8 +182,9 @@
     if res == 81:
         py.test.skip('%r was not compiled w/ required usemodules: %r' %
                      (python_, usemodules))
-    elif res > 0:
-        raise AssertionError("Subprocess failed:\n" + stderr)
+    elif res != 0:
+        raise AssertionError(
+            "Subprocess failed with exit code %s:\n%s" % (res, stderr))
     elif "===aefwuiheawiu===" not in stdout:
         raise AssertionError("%r crashed:\n%s" % (python_, stderr))
 
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
https://mail.python.org/mailman/listinfo/pypy-commit

Reply via email to