Author: Armin Rigo <ar...@tunes.org>
Branch: py3.5
Changeset: r90606:928d214e47b3
Date: 2017-03-09 16:10 +0100
http://bitbucket.org/pypy/pypy/changeset/928d214e47b3/

Log:    test and fix

diff --git a/pypy/module/_io/interp_bufferedio.py 
b/pypy/module/_io/interp_bufferedio.py
--- a/pypy/module/_io/interp_bufferedio.py
+++ b/pypy/module/_io/interp_bufferedio.py
@@ -912,7 +912,6 @@
     # from the mixin class
     __repr__ = interp2app(W_BufferedReader.repr_w),
     readable = interp2app(W_BufferedReader.readable_w),
-    writable = interp2app(W_BufferedReader.writable_w),
     seekable = interp2app(W_BufferedReader.seekable_w),
     seek = interp2app(W_BufferedReader.seek_w),
     tell = interp2app(W_BufferedReader.tell_w),
@@ -954,7 +953,6 @@
 
     # from the mixin class
     __repr__ = interp2app(W_BufferedWriter.repr_w),
-    readable = interp2app(W_BufferedWriter.readable_w),
     writable = interp2app(W_BufferedWriter.writable_w),
     seekable = interp2app(W_BufferedWriter.seekable_w),
     seek = interp2app(W_BufferedWriter.seek_w),
diff --git a/pypy/module/_io/test/test_bufferedio.py 
b/pypy/module/_io/test/test_bufferedio.py
--- a/pypy/module/_io/test/test_bufferedio.py
+++ b/pypy/module/_io/test/test_bufferedio.py
@@ -24,10 +24,12 @@
         raises(ValueError, f.read, -2)
         f.close()
         #
-        raw = _io.FileIO(self.tmpfile)
+        raw = _io.FileIO(self.tmpfile, 'r+')
         f = _io.BufferedReader(raw)
         r = f.read(4)
         assert r == b"a\nb\n"
+        assert f.readable() is True
+        assert f.writable() is False
         f.close()
 
     def test_read_pieces(self):
@@ -320,10 +322,12 @@
 
     def test_write(self):
         import _io
-        raw = _io.FileIO(self.tmpfile, 'w')
+        raw = _io.FileIO(self.tmpfile, 'w+')
         f = _io.BufferedWriter(raw)
         f.write(b"abcd")
         raises(TypeError, f.write, u"cd")
+        assert f.writable() is True
+        assert f.readable() is False
         f.close()
         assert self.readfile() == b"abcd"
 
_______________________________________________
pypy-commit mailing list
pypy-commit@python.org
https://mail.python.org/mailman/listinfo/pypy-commit

Reply via email to