Author: Matti Picus <[email protected]>
Branch: cpyext-obj-stealing
Changeset: r91150:a69664247db2
Date: 2017-04-29 22:53 +0300
http://bitbucket.org/pypy/pypy/changeset/a69664247db2/
Log: fix test
diff --git a/pypy/module/cpyext/test/test_listobject.py
b/pypy/module/cpyext/test/test_listobject.py
--- a/pypy/module/cpyext/test/test_listobject.py
+++ b/pypy/module/cpyext/test/test_listobject.py
@@ -241,8 +241,7 @@
CHECKCOUNT(0, 0, "PyList_SET_ITEM");
tmp = PyList_GET_ITEM(o, 0);
- // XXX should tmp be the original i2?
- // use CPyListStrategy?
+ // XXX should tmp == i2?
if ((Py_REFCNT(tmp) != Py_REFCNT(i2)))
{
sprintf(errbuffer, "GETITEM return (%ld) and i2
(%ld)refcounts"
@@ -258,17 +257,15 @@
PyList_GetItem(o, 0);
CHECKCOUNT(0, 0, "PyList_Get_Item");
- Py_DECREF(o); // decref's stolen reference to i2
- #ifdef PYPY_VERSION
- // XXX TODO
- #else
- if (Py_REFCNT(i1) != 1)
- return PyLong_FromSsize_t(1);
- if (Py_REFCNT(i2) != 1)
- return PyLong_FromSsize_t(2);
+ Py_DECREF(o);
+ #ifndef PYPY_VERSION
+ {
+ // PyPy deletes only at teardown
+ CHECKCOUNT(-1, 0, "Py_DECREF(o)");
+ }
#endif
Py_DECREF(i1); // append incref'd.
- Py_DECREF(i1);
+ Py_DECREF(i2);
return PyLong_FromSsize_t(0);
""")])
assert module.test_refcount_diff() == 0
_______________________________________________
pypy-commit mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-commit
