Hi Christian,

On Wed, Nov 07, 2007 at 02:20:41PM +0100, Christian Tismer wrote:
> > could you please write a couple of tests for this? It's very hard to see 
> > what this code is doing and whether it is broken without tests for its 
> > functionality.
> 
> It is just allowing for less than 4 arguments in __import__.
> Maybe there is a more elegant/bvious way?

The point is that if it's untested, the next time someone needs to
refactor something around this file, your un-checked-in experiments are
going to break, and everybody is going to feel unhappy about it.  So,
can you invest a little time now to avoid long discussions later?
Thanks!


A bientot,

Armin.
_______________________________________________
[email protected]
http://codespeak.net/mailman/listinfo/pypy-dev

Reply via email to