Commited
On Thu, Nov 26, 2009 at 11:24 AM, Armin Rigo <[email protected]> wrote: > Hi Dan, > > On Wed, Nov 25, 2009 at 12:27:27AM -0800, Dan Roberts wrote: >> Thanks for the reply, I've attached a new version of my patch. At first >> glance it would appear I've done little to address your concerns, >> however there's good reason for this. As it turns out, our >> implementation of popen() depends on execvp(), which is only implemented >> in the os module (specifically, the one borrowed from CPython). > > Ah, ok. I see now why there is 'import os' there. So that means that > your patch with 'posix.waitpid' instead of 'os.waitpid' is fine. > > > A bientot, > > Armin. > _______________________________________________ > [email protected] > http://codespeak.net/mailman/listinfo/pypy-dev > _______________________________________________ [email protected] http://codespeak.net/mailman/listinfo/pypy-dev
