I have commited a bunch of changes: - Added cpython baseline to timeline - Changed timeline defaults to both interpreters selected (plus baseline) - Performance improvements in Timeline's ajax: due to above changes, I worried that for a lot of interpreters selected the queries could be too slow. Even though it is known that Premature optimization is the root of all evil (tm), I had a look and optimized django database calls a little bit (or more precisely made my implementation suck less). So instead of nearly 200 ms per interpreter, it now takes less than 100ms (measured locally, add >100ms for network latency). Plot rerendering should feel faster now. I find it interesting how quick django is. Sometimes you may even forget that the data is being pulled from the server each time a different plot is selected. - Timeline: Added labels for the axes - pypy-c-jit appears now listed first - Added tooltips for Host info and for some benchmarks. Copied the descriptions for the benchmarks listed at the unladen site.
Cheers, Miquel 2010/2/25 Leonardo Santagada <[email protected]>: > I also have a bunch of comments, all are my opinion and should not be taken > as demands (or even as a good review). > > - When you first visit the site I think it would be better to be on the > timeline like on http://buildbot.pypy.org/plotsummary.html that shows all > benchmarks on the same page, but just the last 50 revisions or it becomes too > hard to see the recent improvements. (being able to show more history is > important too, maybe there is a way to show the trend and the last x > revisions clearly). > > - Overview window comments: > - rename the column "result" to "time" (or timing?); > - create a new column called "previous time" with the last time of the > previous revision. > - rename "current change" to "improvement" and invert the values > (instead of a green -2% you end up with a green 2%); > - with the last two ones it will make understanding the improvement > and trends a lot easier; > - trend should have the number of revisions on the label (and the > values reversed like the "improvement" column); > - rename the column "times cpython" to something else (eg. "compared > to cpython") and maybe have values like "2x slow down" and "2.5x speedup"; > - the graph should say what it is graphing; > - maybe invert the order of results. > > - Timeline window comments: > - showing all benchmarks in the same page would be good > - Pypy with jit should come first in the list of interpreters, and > while you only test with hybrid gc there is no need to state that explicitly; > - see all benchmarks together, so you don't have to hunt around (maybe > have a detailed view); > - describe all axis; > - as armin said have a selected by default cpython comparison so > people can have a baseline. > > > I think this speed center could be used for the common mercurial benchmark > repository that is being setup, that would be very very cool. > > > On Feb 25, 2010, at 6:18 AM, Armin Rigo wrote: > >> Hi Miquel, >> >> May I point out a couple of comments about http://speed.pypy.org/ ? >> The first is that it looks great, indeed; thank you very much for doing >> such a site! :-) >> >> The comments are mostly about the graphics in /timeline: >> >> * they should also display, or allow to display, the speed of CPython >> for comparison; >> >> * they should have a longer maximum history than 100, to see more >> clearly the long-term evolution. >> >> >> All in all it looks great! >> >> A bientot, >> Armin. >> _______________________________________________ >> [email protected] >> http://codespeak.net/mailman/listinfo/pypy-dev > > -- > Leonardo Santagada > santagada at gmail.com > > > > _______________________________________________ [email protected] http://codespeak.net/mailman/listinfo/pypy-dev
