Hello, 2011/8/21 Mitchell Hashimoto <mitchell.hashim...@gmail.com>
> I noticed the 'os' module is incomplete, and I'd like to help complete > this. > You are very welcome! > CPython does this by simply having these methods available on "posix" "nt" > "os2" etc. and the "os" module imports those. It appears that PyPy does the > same thing. I was able to successfully add 'getlogin' as practice, but I > wanted to post here before going further. Some questions below: > > 1.) Should I mimic CPython and add the functionality to the OS-specific > modules? > Yes we should mimic CPython: fortunately these modules have different names but share the same source file. With CPython it's Modules/posixmodule.c, with PyPy it's in pypy/module/posix. > 2.) I don't have a Windows computer on hand. What is the standard practice > for implementing some stdlib for one OS but not the other? Would PyPy accept > this temporarily? > Yes, no problem. In this case, I think it's best to let the test fail on Windows so that someone may notice and fix it. > 3.) There are many missing methods, to simplify implementation time and the > patch, would it be okay to submit a patch for each stdlib method, so that > this was built up over time? > Yes, smaller patches are easier to read and merge. I'd be happy to review and commit them. -- Amaury Forgeot d'Arc
_______________________________________________ pypy-dev mailing list pypy-dev@python.org http://mail.python.org/mailman/listinfo/pypy-dev
