On 04/12/2013 10:01 AM, Armin Rigo wrote:
Hi all,
Another way to write the test_pypy_c: you add the test with the input,
and write some rough approximation of the output you expect --- maybe
with comments explaining what you roughly expect. Then you check this
in together with the changes in the jit. It will fail in the next
(nightly or manual) build, but then you should know what you really
got. You can then check and fix the test. I think it's a situation
where it's ok to check in a test that we know is failing, and we're
going to fix it soon. This works assuming there are enough
information on the buildbot page; if not, well, improve the
test_pypy_c/model.py file too :-)
I like this approach, because at least then the commit mail shows that
the person doing the change has thought about testing, and things don't
get lost.
Cheers,
Carl Friedrich
_______________________________________________
pypy-dev mailing list
pypy-dev@python.org
http://mail.python.org/mailman/listinfo/pypy-dev
