Thanks for taking a look.
My immediate goal is to get micronumpy tests passing on ARM.
micronumpy uses raw_storage_getitem, which needs to be fixed. I thought
nonaligned access would be a problem in other parts of pypy, but do not
have the perspective to judge that, so I tried to stick xxx in all
raw_load places in the code base, whether needed or not. In retrospect,
that may be overkill, and it may be enough to fix for a few cases in
micronumpy (reading from a user-supplied buffer or from a record array)
and, as you point out, ctypes.
What about struct.unpack() ?
Matti
On 02/22/2014 10:30 AM, Armin Rigo wrote:
Hi Matti,
On 18 February 2014 14:05, matti picus <matti.pi...@gmail.com> wrote:
I would like to ask for help with this branch, as I have not been able to
move it forward fast enough.
I moved it forward a little bit, but now I'm wondering if it actually
makes sense. What is the goal? Is it to fix a problem in ctypes
only, by fixing pypy/module/_rawffi? If that's the case, then we
might as well write the hack locally in _rawffi, e.g. by using
different versions of the helpers there depending on whether we get
aligned or misaligned pointers. This certainly looks cleaner than
adding raw_load_unaligned and raw_store_unaligned *everywhere*
including in the JIT.
A bientôt,
Armin.
_______________________________________________
pypy-dev mailing list
pypy-dev@python.org
https://mail.python.org/mailman/listinfo/pypy-dev
