looking at this test failure
http://buildbot.pypy.org/summary/longrepr?testname=test_math&builder=own-win-x86-32&build=86&mod=jit.backend.x86.test.test_zmath
which tests that atan2(0.23/1.23) == 1.3.... via OP_FLOAT_EQ(double value,
double value)
OP_FLOAT_EQ is a compiler define to (a == b), which is tricky with double
values.
Here is a nice discussion of the issue on MSVC
http://www.gamasutra.com/view/news/167402/Indepth_Intermediate_floatingpoint_precision.php
The link even has a flow chart for choosing msvc or intel compiler flags.
The test passes if I add /fp:fast to the msvc compile flag
Would anyone object if I add this to the default MSVC flags?

FWIW, the "fast" is misleading, apparently it can be slower than the
default for some cases.
Matti
_______________________________________________
pypy-dev mailing list
[email protected]
https://mail.python.org/mailman/listinfo/pypy-dev

Reply via email to