Hi again, for more details, look at 77dce024e344. It takes the original approach of not touching operations using opaque pointers at all into one that allows getfield_gc(p,...) with p opaque in the short_preamble in some specific cases.
On Tue, Oct 14, 2014 at 9:55 AM, Hakan Ardo <ha...@debian.org> wrote: > On Tue, Oct 14, 2014 at 9:26 AM, Armin Rigo <ar...@tunes.org> wrote: >> >> I'm not sure: the logic in optimizeopt/heap.py seems to be "if it's an >> opaque pointer, and if we don't know its class, then don't move it". >> According to this logic, operations on RPython instances (like >> GUARD_CLASS) can still be moved to the short preamble. Maybe I'm >> missing something else? > > I see. Yes, there is the logic of ShortBoxes.assumed_classes which is > supposed to make sure never to inline a short_preamble in cases where > the class of the opaque pointer is not already known. This logic could > probably be killed with your solution. > > -- > Håkan Ardö -- Håkan Ardö _______________________________________________ pypy-dev mailing list pypy-dev@python.org https://mail.python.org/mailman/listinfo/pypy-dev
