So it's correct that I can't see the change to fix this in the public repo develop branch?
On Sunday, March 20, 2016 at 3:11:18 PM UTC, Luke Campagnola wrote: > > That's correct; the bug has been fixed in github but the fix hasn't been > released yet. > > > On Sat, Mar 19, 2016 at 9:28 PM, <[email protected] <javascript:>> wrote: > >> It looks like this has still not been fixed. Using version 0.9.10, I get >> an error caused by the 'd2 *= scale' line when I use setFrame() with an >> uint8 array >> >> TypeError: Cannot cast ufunc multiply output from dtype('float64') to >> dtype('uint8') with casting rule 'same_kind' >> >> >> On Monday, September 2, 2013 at 7:07:25 PM UTC-7, Antony Lee wrote: >>> >>> Hi, >>> >>> I would suggest patching the last few lines of rescaleData as follows: >>> >>> - d2 = data-offset >>> - d2 *= scale >>> - data = d2.astype(dtype) >>> + data = (data.astype(dtype) - offset) * scale >>> >>> The reason is that sometimes, d2 *= scale will trigger a RuntimeWarning, >>> e.g. if data happens to be an uint16 and the multiplication by a large >>> scale (that is a float64) triggers a RuntimeWarning, even though we will >>> want to cast the data to float64 immediately after anyways. >>> >>> As a side note, while I haven't tried it, I would guess that the weave >>> implementation of rescaleData can't be faster than a simple numpy >>> expression ("(data.astype(dtype) - offset) * scale") if it must invoke a >>> compiler every time... >>> >>> Antony >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "pyqtgraph" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/pyqtgraph/1be22f6e-e1bd-4ff0-afa9-d2b54b8a2f59%40googlegroups.com >> >> <https://groups.google.com/d/msgid/pyqtgraph/1be22f6e-e1bd-4ff0-afa9-d2b54b8a2f59%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "pyqtgraph" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/pyqtgraph/e5840a0c-21c9-41c8-8882-fa9bcaff9580%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
