Oh, git bisect when the issue is fixed/broken multiple times over is so much ...."fun"
I would have thought that https://github.com/pyqtgraph/pyqtgraph/pull/2034 would fix the issue you're having (merged 5 days ago, after 0.12.3 release)... I'll try and take a closer look in the next few days. If you're dealing with axis and mouse related mapping issues, I would look for errenous use cases of `event.pos()` (where you should use event.scenePos()) or things of that nature. Quite possible that one of the use-cases got missed someplace. On Tue, Oct 26, 2021 at 11:47 AM Israel Brewster <[email protected]> wrote: > On Oct 26, 2021, at 8:17 AM, Ognyan Moore <[email protected]> wrote: > > Hi Israel, > Depending on how easy it is to apply your patches to pyqtgraph within your > example, could you try running a git-bisect from the master branch and see > if you can zero in on the first problematic commit? > > > Ok, that proved…interesting. > > Up to and including commit 3a3d05b1, all looks fine. > Starting with the next commit - 61f067bf - horizontal zoom dies completely > - using the scroll wheel results in only the vertical axis zooming in or > out (unless the mouse is over the horizontal axis). > This is fixed at commit 775f1d62, but with the grid now being an issue, > causing the zoom to see the mouse at a different x position than expected. > > So perhaps commit 61f067bf introduced both issues (no horizontal zoom and > the x offset of the zoom location), and commit 775f1d62 only fixed one of > them? Maybe? > > --- > Israel Brewster > Software Engineer > Alaska Volcano Observatory > Geophysical Institute - UAF > 2156 Koyukuk Drive > Fairbanks AK 99775-7320 > Work: 907-474-5172 > cell: 907-328-9145 > > > On Tue, Oct 26, 2021 at 8:47 AM Israel Brewster <[email protected]> > wrote: > >> Well, the minimal example I tried showed proper expected zoom behavior, >> so it must be something in my code, interacting with some innocuous change >> in PyQtGraph. Time to start digging! >> --- >> Israel Brewster >> Software Engineer >> Alaska Volcano Observatory >> Geophysical Institute - UAF >> 2156 Koyukuk Drive >> Fairbanks AK 99775-7320 >> Work: 907-474-5172 >> cell: 907-328-9145 >> >> On Oct 22, 2021, at 11:49 AM, Ognyan Moore <[email protected]> >> wrote: >> >> Hi Israel, >> >> Good to hear from you. We had a lot of changes in 0.12.3 (one day we'll >> do a release with only a few changes), but I can't think of anything that >> would have broken mouse behavior. >> >> That said, just yesterday, I did merge an issue that does effect zooming, >> the issue was noticeable when the grid was displayed; but the issue it >> addresses is/was quite old. If you can, I would try and give `master` >> branch a chance, otherwise, if a minimum reproducible example is out of the >> question, I would attempt to do some kind of git bisect and see if you can >> zero in on the commit that started causing the problem to begin with. >> >> Ogi >> >> On Fri, Oct 22, 2021 at 11:00 AM Israel Brewster <[email protected]> >> wrote: >> >>> Just (finally!) got around to upgrading my project to pyqtgraph 0.12.3, >>> and now rather than zooming around the mouse when using the “scroll wheel” >>> (two-finger drag on the trackpad) to zoom in/out, it seems to zoom from >>> some point on the left edge of the graph. Is this a change/issue with the >>> new version of pyqtgraph, or something due to the many (many!) >>> overrides/tweaks I have made to the behavior of pyqtgraph throughout my >>> code? >>> --- >>> Israel Brewster >>> Software Engineer >>> Alaska Volcano Observatory >>> Geophysical Institute - UAF >>> 2156 Koyukuk Drive >>> Fairbanks AK 99775-7320 >>> Work: 907-474-5172 >>> cell: 907-328-9145 >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "pyqtgraph" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/pyqtgraph/D7D8C7C8-266A-480C-967D-7E3E8660BD27%40alaska.edu >>> <https://groups.google.com/d/msgid/pyqtgraph/D7D8C7C8-266A-480C-967D-7E3E8660BD27%40alaska.edu?utm_medium=email&utm_source=footer> >>> . >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "pyqtgraph" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/pyqtgraph/CA%2BnduTF8%3DXi20rGQxywn%3DPJYzx2B%2B_KqsR89qL4FOdzxD-RCXQ%40mail.gmail.com >> <https://groups.google.com/d/msgid/pyqtgraph/CA%2BnduTF8%3DXi20rGQxywn%3DPJYzx2B%2B_KqsR89qL4FOdzxD-RCXQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "pyqtgraph" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/pyqtgraph/CBED70C4-96C3-431C-BDE9-6379BB30E855%40alaska.edu >> <https://groups.google.com/d/msgid/pyqtgraph/CBED70C4-96C3-431C-BDE9-6379BB30E855%40alaska.edu?utm_medium=email&utm_source=footer> >> . >> > > -- > You received this message because you are subscribed to the Google Groups > "pyqtgraph" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/pyqtgraph/CA%2BnduTEJ0hszKbwsvHPSZ8JH1g%3DL-vj%2BG8K73_iCF9q5qW9Tvg%40mail.gmail.com > <https://groups.google.com/d/msgid/pyqtgraph/CA%2BnduTEJ0hszKbwsvHPSZ8JH1g%3DL-vj%2BG8K73_iCF9q5qW9Tvg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > -- > You received this message because you are subscribed to the Google Groups > "pyqtgraph" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/pyqtgraph/B5BC0B73-697D-452C-B3A9-14691ADCD362%40alaska.edu > <https://groups.google.com/d/msgid/pyqtgraph/B5BC0B73-697D-452C-B3A9-14691ADCD362%40alaska.edu?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "pyqtgraph" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/pyqtgraph/CA%2BnduTGZqHtNcDW2Q6htJSXSKQ6c%3Dn7vQcDr%3DNZmj9eizBddPg%40mail.gmail.com.
