Hi Kris,
No worries. Github has a very detailed page on pull requests (
http://help.github.com/send-pull-requests/).
First you'll need to fork your PyTables into your own remote repo. Then,
you'll want to create a remote fork branch locally, and point this to your
fork. Make your changes locally and push them back up to your fork. Then
go to github and submit a pull request.
Easy, right ;). Actually, once you have a good mental model of how this
works (there are some great figures online), it is a really effective way to
work. Let us know if you have any other questions.
Be Well
Anthony
On Tue, Sep 6, 2011 at 2:46 PM, Chris Kees <cek...@gmail.com> wrote:
> Hi Antonio and Anthony,
>
> I'm using the git hub version, so I'll pull the latest changes to the
> master, check this issue again, and then submit a pull request with
> the fix to setup.py. I've never submitted a pull request so please let
> me know if there are any tricks I need to know. Otherwise I'll figure
> out how to do it from the github documentation. Also, sorry for the
> slow response.
>
> Chris
>
> On Fri, Sep 2, 2011 at 1:38 PM, Antonio Valentino
> <antonio.valent...@tiscali.it> wrote:
> > Hi Chris,
> >
> > Il 02/09/2011 16:47, Chris Kees ha scritto:
> >> Hi,
> >>
> >> Would it be possible to patch the setup.py so that it searches for the
> >> runtime libraries in the provided path for hdf5 rather than just a set
> >> of default directories? We frequently have to install on systems where
> >> we don't have access to the default directories and have to append to
> >> LD_LIBRARY_PATH/DYLD_LIBRARY_PATH. The current version setup.py always
> >> generates a warning for us (and is actually finding the wrong hdf5
> >> runtime when it DOESN'T generate a warning). Here's what I'm
> >> proposing:
> >
> > With "The current version setup.py" do you mean the one from the
> > PyTables 2.2 package tarball?
> >
> > In case, it would be nice if you could give a try to the latest version
> > currently in master on github
> >
> > https://github.com/PyTables/PyTables/
> >
> > There is another small patch on my personal area
> >
> >
> https://github.com/avalentino/PyTables/commit/6e6c9ad7a09bfd97310a2ef8ed1ea526b11acc1e
> >
> > that could be useful in this case.
> >
> > Also it would be useful if you could give us more details (e.g. the
> > exact command line, setup.py output, relevant environment and so on).
> >
> >> --- a/setup.py
> >> +++ b/setup.py
> >> @@ -155,7 +155,7 @@ class Package(object):
> >> # An explicit path can not be provided for runtime libraries.
> >> # (The argument is accepted for compatibility with previous
> methods.)
> >> return _find_file_path(
> >> - self.runtime_name, default_runtime_dirs,
> >> + self.runtime_name, locations,
> >> self._runtime_prefixes, self._runtime_suffixes )
> >>
> >>
> >> -Chris
> >
> >
> > Thanks
> >
> > --
> > Antonio Valentino
> >
> >
> ------------------------------------------------------------------------------
> > Special Offer -- Download ArcSight Logger for FREE!
> > Finally, a world-class log management solution at an even better
> > price-free! And you'll get a free "Love Thy Logs" t-shirt when you
> > download Logger. Secure your free ArcSight Logger TODAY!
> > http://p.sf.net/sfu/arcsisghtdev2dev
> > _______________________________________________
> > Pytables-users mailing list
> > Pytables-users@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/pytables-users
> >
>
>
> ------------------------------------------------------------------------------
> Malware Security Report: Protecting Your Business, Customers, and the
> Bottom Line. Protect your business and customers by understanding the
> threat from malware and how it can impact your online business.
> http://www.accelacomm.com/jaw/sfnl/114/51427462/
> _______________________________________________
> Pytables-users mailing list
> Pytables-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/pytables-users
>
------------------------------------------------------------------------------
Malware Security Report: Protecting Your Business, Customers, and the
Bottom Line. Protect your business and customers by understanding the
threat from malware and how it can impact your online business.
http://www.accelacomm.com/jaw/sfnl/114/51427462/
_______________________________________________
Pytables-users mailing list
Pytables-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pytables-users
