Branch: refs/heads/master
Home: https://github.com/pytest-dev/pytest
Commit: 05796be21a4421e5f76893afd34140706a71b42b
https://github.com/pytest-dev/pytest/commit/05796be21a4421e5f76893afd34140706a71b42b
Author: Segev Finer <segev...@gmail.com>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M _pytest/capture.py
Log Message:
-----------
A workaround for Python 3.6 WindowsConsoleIO breaking with FDCapture
Python 3.6 implemented unicode console handling for Windows. This works
by reading/writing to the raw console handle using
``{Read,Write}ConsoleW``.
The problem is that we are going to ``dup2`` over the stdio file
descriptors when doing ``FDCapture`` and this will ``CloseHandle`` the
handles used by Python to write to the console. Though there is still some
weirdness and the console handle seems to only be closed randomly and not
on the first call to ``CloseHandle``, or maybe it gets reopened with the
same handle value when we suspend capturing.
The workaround in this case will reopen stdio with a different fd which
also means a different handle by replicating the logic in
"Py_lifecycle.c:initstdio/create_stdio".
See https://github.com/pytest-dev/py/issues/103
Commit: 59b3693988fcc19a9f5d7aa5c31cc7de28fcf6b7
https://github.com/pytest-dev/pytest/commit/59b3693988fcc19a9f5d7aa5c31cc7de28fcf6b7
Author: Segev Finer <segev...@gmail.com>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M _pytest/capture.py
Log Message:
-----------
Fixed wrong if in the WindowsConsoleIO workaround
Commit: 01ed6dfc3bd29b2d76d3e9ed079f2f0f648c0179
https://github.com/pytest-dev/pytest/commit/01ed6dfc3bd29b2d76d3e9ed079f2f0f648c0179
Author: Segev Finer <segev...@gmail.com>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
A changelog/103.bugfix
Log Message:
-----------
Added a changelog entry for the WindowsConsoleIO workaround
Commit: 1863b7c7b263b3161c7ac79854db37ab67919529
https://github.com/pytest-dev/pytest/commit/1863b7c7b263b3161c7ac79854db37ab67919529
Author: Bruno Oliveira <nicodde...@gmail.com>
Date: 2017-06-03 (Sat, 03 Jun 2017)
Changed paths:
M _pytest/capture.py
A changelog/103.bugfix
Log Message:
-----------
Merge pull request #2462 from segevfiner/py36-windowsconsoleio-workaround
[WIP] A workaround for Python 3.6 WindowsConsoleIO breaking with FDCapture
Compare:
https://github.com/pytest-dev/pytest/compare/f826b23f588f...1863b7c7b263_______________________________________________
pytest-commit mailing list
pytest-commit@python.org
https://mail.python.org/mailman/listinfo/pytest-commit
