On 1 August 2014 23:09, Floris Bruynooghe <f...@devork.be> wrote: > So datadiff is not as good as comparing strings then what py.test does now? > > it doesn't even support such comparison - raises notimplemented
> We should always strive to make the assertions better. If you think > they can be improved using datadiff then let's improve it. The > current reprs where simply derived from unittest2 with some > improvements from feedback later. > > +1 > > the reason why im asking without the PR is the politics about the > > dependencies > > as i know you're not so positive about adding them > > I guess new external dependencies are not ideal. But looking at > datadiff it seems to be only about 300 lines of Apache licensed code. > That's not a lot of code by any means. So I think there are a few > options which I think are realistic: > > * Vendor datadiff, I think the licenses are compatible. > by vendoring you mean using it as a dependency? if so, then i also prefer this way the author seems doing something at sourgeforge, so he's alive, and we can ask for PR if they will be needed about having datadiff diffs as external plugin, not putting it in the core - that was more like sandboxing approach, i think and i think it's good intention -- Anatoly Bubenkov
_______________________________________________ Pytest-dev mailing list Pytest-dev@python.org https://mail.python.org/mailman/listinfo/pytest-dev
