Done: https://github.com/pytest-dev/pytest/pull/959
Comments are welcome! Cheers, Bruno. On Tue, Aug 25, 2015 at 12:53 PM Bruno Oliveira <[email protected]> wrote: > On Tue, Aug 25, 2015 at 12:34 PM Floris Bruynooghe <[email protected]> wrote: > >> On 25 August 2015 at 14:10, Floris Bruynooghe <[email protected]> wrote: >> > On 25 August 2015 at 12:58, Bruno Oliveira <[email protected]> >> wrote: >> >> >> How about: >> >> >> >> * Create a script which fetches the latest pluggy version, and >> installs it >> >> into `_pytest.vendor.pluggy`; >> >> * Add `_pytest.vendor.pluggy` to version control >> >> * Update all references in pytest from `pluggy` to >> `_pytest.vendor.pluggy`; >> >> * Remove the dependency from `setup.py`; >> >> Actually your proposal is much easier to implement and the only real >> downside is that distributions will have a harder time un-bundling it. >> Not sure how big a deal that is. But this approach is fine to me, it >> would still allow for an optional bunch of setup.py trickery to skip >> installing the vendored pluggy later if needed. >> > > I agree. :) > > I just realized that `pip install` supports a `--target` parameter, so it > is even simpler. If nobody disagrees, I will work on this then: > > * Create `_pytest.vendor`; > * Execute `pip install pluggy --target-dir=_pytest/vendor`; > * Add a README to _pytest.vendor explaining things (or to > vendor.__init__.py); > * Update imports > * Remove pluggy as a dependency. > > I think this is simple to implement and will fit our needs nicely. > > Cheers, > Bruno. >
_______________________________________________ pytest-dev mailing list [email protected] https://mail.python.org/mailman/listinfo/pytest-dev
