Hey,

On Thu, Oct 04, 2018 at 10:19:21AM -0300, Bruno Oliveira wrote:
> This new exception type (I've used UsageError on my PR just for proof of
> concept) should be part of the public API so plugins can also use it.
> 
> I'm writing to the ML because it would be beneficial to get feedback from a
> larger audience about what the *name* of the exception should be.
> 
> UserError? InternalError?

I dislike both, but without having a better idea (sorry :D). Here's why:

UsageError is dangerously close to UsageError. It's also not clear
from the name why they differ.

InternalError sounds like the exceptions prefixed with INTERNALERROR>,
(i.e. unhandled exceptions inside pytest), which seems like the exact
opposite of what this is.

Maybe we should rename UsageError to CliUsageError, or make sure
UsageError is usable for this purpose?

Florian

-- 
https://www.qutebrowser.org | m...@the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc
         I love long mails! | https://email.is-not-s.ms/

Attachment: signature.asc
Description: PGP signature

_______________________________________________
pytest-dev mailing list
pytest-dev@python.org
https://mail.python.org/mailman/listinfo/pytest-dev

Reply via email to