Author: guido.van.rossum
Date: Mon Jul 23 03:49:28 2007
New Revision: 56500
Modified:
python/branches/py3k-struni/Lib/test/test_poplib.py
Log:
Don't use a sleep to wait for the server to be ready; this caused
problems on my OSX laptop. use a condition variable instead.
Modified: python/branches/py3k-struni/Lib/test/test_poplib.py
==============================================================================
--- python/branches/py3k-struni/Lib/test/test_poplib.py (original)
+++ python/branches/py3k-struni/Lib/test/test_poplib.py Mon Jul 23 03:49:28 2007
@@ -7,12 +7,13 @@
from test import test_support
-def server(evt):
+def server(ready, evt):
serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
serv.settimeout(3)
serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
serv.bind(("", 9091))
serv.listen(5)
+ ready.set()
try:
conn, addr = serv.accept()
except socket.timeout:
@@ -28,8 +29,9 @@
def setUp(self):
self.evt = threading.Event()
- threading.Thread(target=server, args=(self.evt,)).start()
- time.sleep(.1)
+ self.ready = threading.Event()
+ threading.Thread(target=server, args=(self.ready, self.evt,)).start()
+ self.ready.wait()
def tearDown(self):
self.evt.wait()
_______________________________________________
Python-3000-checkins mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-3000-checkins