On Nov 18, 2007 1:30 PM, christian.heimes
<[email protected]> wrote:
> Author: christian.heimes
> Date: Sun Nov 18 22:30:36 2007
> New Revision: 59042
>
> Modified:
>    python/branches/py3k/Modules/xxmodule.c
> Log:
> I'm using the xxmodule and xxsubtype to test the msvccompiler on Windows. I'm 
> having trouble to compile the module with VS 2008 cl.exe because "initializer 
> is not a constant".
>

Can't you do this testing in your own checkout without committing the
change until you have talked to python-dev about the idea of changing
how all types are initialized?

-Brett


> Modified: python/branches/py3k/Modules/xxmodule.c
> ==============================================================================
> --- python/branches/py3k/Modules/xxmodule.c     (original)
> +++ python/branches/py3k/Modules/xxmodule.c     Sun Nov 18 22:30:36 2007
> @@ -246,7 +246,7 @@
>         0,                      /*tp_methods*/
>         0,                      /*tp_members*/
>         0,                      /*tp_getset*/
> -       &PyUnicode_Type,        /*tp_base*/
> +       0,                      /*tp_base*/
>         0,                      /*tp_dict*/
>         0,                      /*tp_descr_get*/
>         0,                      /*tp_descr_set*/
> @@ -301,7 +301,7 @@
>         0,                      /*tp_methods*/
>         0,                      /*tp_members*/
>         0,                      /*tp_getset*/
> -       &PyBaseObject_Type,     /*tp_base*/
> +       0,                      /*tp_base*/
>         0,                      /*tp_dict*/
>         0,                      /*tp_descr_get*/
>         0,                      /*tp_descr_set*/
> @@ -341,6 +341,9 @@
>  {
>         PyObject *m;
>
> +       Null_Type.tp_base = &PyBaseObject_Type;
> +       Str_Type.tp_base = &PyUnicode_Type;
> +
>         /* Finalize the type object including setting type of the new type
>          * object; doing it here is required for portability to Windows
>          * without requiring C++. */
> _______________________________________________
> Python-3000-checkins mailing list
> [email protected]
> http://mail.python.org/mailman/listinfo/python-3000-checkins
>
_______________________________________________
Python-3000-checkins mailing list
[email protected]
http://mail.python.org/mailman/listinfo/python-3000-checkins

Reply via email to