I know I was lax and didn't include full unittests for these -- but now that they are maturing, perhaps someone could add some? This and the previous slip would have caught by pretty basic unittests...
--Guido On Feb 5, 2008 4:10 AM, raymond.hettinger <python-3000-checkins@python.org> wrote: > Author: raymond.hettinger > Date: Tue Feb 5 13:10:29 2008 > New Revision: 60591 > > Modified: > python/branches/py3k/Lib/_abcoll.py > Log: > Fix-up mapping equality tests to include both keys and values > > Modified: python/branches/py3k/Lib/_abcoll.py > ============================================================================== > --- python/branches/py3k/Lib/_abcoll.py (original) > +++ python/branches/py3k/Lib/_abcoll.py Tue Feb 5 13:10:29 2008 > @@ -379,10 +379,10 @@ > return ValuesView(self) > > def __eq__(self, other): > - return set(self) == set(other) > + return dict(self.items()) == dict(other.items()) > > def __ne__(self, other): > - return set(self) != set(other) > + return dict(self.items()) != dict(other.items()) > > class MappingView(metaclass=ABCMeta): > > _______________________________________________ > Python-3000-checkins mailing list > Python-3000-checkins@python.org > http://mail.python.org/mailman/listinfo/python-3000-checkins > -- --Guido van Rossum (home page: http://www.python.org/~guido/) _______________________________________________ Python-3000-checkins mailing list Python-3000-checkins@python.org http://mail.python.org/mailman/listinfo/python-3000-checkins
