Another thing that needs to be ported are the changes to Lib/test/regrtest.py. Pretty much anything that references ABCs in there needs backporting. You can verify it works properly by running regrtest.py with the -R option on any test that uses an ABC. It should not report leaks. The full command line should look something like: ./python Lib/test/regrtest.py -R 4:3 test_abc
n -- On 8/26/07, Benjamin Aranguren <[EMAIL PROTECTED]> wrote: > I got it now. both modules need to be backported as well. I'm on it. > > On 8/26/07, Benjamin Aranguren <[EMAIL PROTECTED]> wrote: > > No problem. Created issue 1026 in tracker with a single patch file > > attached. > > > > I'm not aware of what changes need to be done with _abcoll.py and > > collections.py. If you can point me to the right direction, I would > > definitely like to work on it. > > > > On 8/26/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > > Thanks! > > > > > > Would it inconvenience you terribly to upload this all to the new > > > tracker (bugs.python.org)? Preferably as a single patch against the > > > svn trunk (to use svn diff, you have to svn add the new files first!) > > > > > > Also, are you planning to work on _abcoll.py and the changes to > > > collections.py? > > > > > > --Guido > > > > > > On 8/26/07, Benjamin Aranguren <[EMAIL PROTECTED]> wrote: > > > > We copied abc.py and test_abc.py from py3k svn and modified to work > > > > with 2.6. > > > > > > > > After making all the changes we ran all the tests to ensure that no > > > > other modules were affected. > > > > > > > > Attached are abc.py, test_abc.py, and their relevant patches from 3.0 > > > > to 2.6. > > > > > > > > On 8/25/07, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > > > > Um, that patch contains only the C code for overloading isinstance() > > > > > and issubclass(). > > > > > > > > > > Did you do anything about abc.py and _abcoll.py/collections.py and > > > > > their respective unit tests? Or what about the unit tests for > > > > > isinstance()/issubclass()? > > > > > > > > > > On 8/25/07, Benjamin Aranguren <[EMAIL PROTECTED]> wrote: > > > > > > Worked with Alex Martelli at the Goolge Python Sprint. > > > > > > > > > > -- > > > > > --Guido van Rossum (home page: http://www.python.org/~guido/) > > > > > > > > > > > > > > > > > > > > > > -- > > > --Guido van Rossum (home page: http://www.python.org/~guido/) > > > > > > _______________________________________________ > Python-3000 mailing list > Python-3000@python.org > http://mail.python.org/mailman/listinfo/python-3000 > Unsubscribe: > http://mail.python.org/mailman/options/python-3000/nnorwitz%40gmail.com > _______________________________________________ Python-3000 mailing list Python-3000@python.org http://mail.python.org/mailman/listinfo/python-3000 Unsubscribe: http://mail.python.org/mailman/options/python-3000/archive%40mail-archive.com
