Bugs item #1016563, was opened at 2004-08-26 08:14
Message generated for change (Comment added) made by pmoore
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1016563&group_id=5470
Category: Python Library
Group: Python 2.4
Status: Open
Resolution: None
Priority: 6
Submitted By: Christoph Mussenbrock (mussenbrock)
Assigned to: Jeremy Hylton (jhylton)
Summary: urllib2 bug in proxy auth
Initial Comment:
in urllib2.py:
line 502 should be:
... user_pass = base64.encodestring('%s:%s' % (unquote
(user), unquote(password))).strip()
the '.strip()' is missing in the current version ("2.1").
this makes an additonal '\n' at the end of user_pass.
So there will be an empty line in the http header, which
is buggy.
(see also line 645, where the .strip() is right in place!).
Best regards,
Christoph
----------------------------------------------------------------------
Comment By: Paul Moore (pmoore)
Date: 2005-01-29 21:50
Message:
Logged In: YES
user_id=113328
The change was introduced by revision 1.32 of the file, from
patch 527518. There's no mention of removing strip() there,
so I suspect it was an accident.
The strip() is still missing in CVS HEAD. I can see the
problem, in theory (base64.encodestring returns a string
with a terminating newline). However, I cannot reproduce the
problem.
Can the original poster provide a means of verifying the
problem? It may be useful as a test case.
Regardless, the change seems harmless, and can probably be
applied. I attach a patch against CVS HEAD:
--- urllib2.py.orig 2005-01-09 05:51:49.000000000 +0000
+++ urllib2.py 2005-01-29 21:31:49.000000000 +0000
@@ -582,7 +582,8 @@
if ':' in user_pass:
user, password = user_pass.split(':', 1)
user_pass = base64.encodestring('%s:%s' %
(unquote(user),
-
unquote(password)))
+
unquote(password))
+ ).strip()
req.add_header('Proxy-authorization',
'Basic ' + user_pass)
host = unquote(host)
req.set_proxy(host, type)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1016563&group_id=5470
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
