Filip Gruszczyński <[email protected]> added the comment:
The reason for the use of two constants is that previously there was comparison
in the code with a hardcoded 'f':
if postdev[0] == 'f':
I think it's a common practice to create constants for such hardcoded values.
Also this hit when I was making a patch. I didn't know, that 'f' was used in
the code and when I changed _FINAL_MARKER to ('f',), some tests failed.
Alternatively to what I did in the patch you can use:
if postdev[0] == _FINAL_MARKER[0]:
but it just doesn't feel right for me.
Anyway, I can't find packaging package in default branch of python. Where is
the development done? I'd be happy to try to provide some more patches for this
package, if there is a need for any.
----------
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue11841>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
