Antoine Pitrou <pit...@free.fr> added the comment: Le mardi 26 avril 2011 à 01:34 +0000, STINNER Victor a écrit : > STINNER Victor <victor.stin...@haypocalc.com> added the comment: > > > > - Rename _PyThread_Info() to PyThread_GetInfo() (consistent name with > > > PyFloat_GetInfo() and PyLong_GetInfo()) > > > > I don't think we want that API to be public, so it should be > > _PyThread_GetInfo(). > > Why should it be private in C, but not in Python?
Well, if it's called _info() in Python, it's private too! > > > - Always compile thread.c, but add #ifdef WITH_THREAD around most the > > > file (except PyThread_GetInfo()) > > > > What's the point? Sounds like pointless complication. > > Complication? It does *simplify* configure.in. > > I don't want to create a new file just for a small function. What I mean is that the "#ifdef WITH_THREAD" could be done in sysmodule.c rather than in thread.c Also, when Python is compiled without threads, I don't think thread_info should be a structseq. It should probably be None instead. Another small thing: your doc says "name" is optional, but it shouldn't. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue11223> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
