Ezio Melotti <ezio.melo...@gmail.com> added the comment: > I think that the patch is simple (it adds 3 "with+simplefilter") and it > doesn't add "complexity", or you should define what complexity is :-)
The patch is indeed quite simple. but with it half of the code in _baseAssertEqual will be to deal with warnings for this corner case. > Buildbots use "make buildbottest" which run python with -bb Yes, but "make buildbottest" is used just by the buildbots afaik. > No. You have usually more failures with -bb than without any -b flag. > Not in test itself, but in a function called by the test. That's what I meant, the tests will still work with -bb and the failures will be elsewhere (i.e. the patch won't change anything here). > A test may only fail with -bb. If the failure is in the test, I would say that the test is probably wrong (see e.g. the assertNotEqual example in my previous message), if the failure is elsewhere the patch won't change anything. > Anyway, my problem is to be able to get more informations on a > failure in a buildbot. I cannot change (easily) -bb flags on the > buildbots [...] On this I agree (that's why I'm -0.5 and not -1), but as I said it's a very specific situation, and my gut feeling is that it might not be worth fixing it. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue11887> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
