Petri Lehtinen <pe...@digip.org> added the comment:

I'd call os.path.join() in the test functions rather than in read_file() and 
write_file(). This makes it easier to understand what the test is doing without 
looking at the code of read_file() and write_file().

Otherwise, looks good to me, and I think this would be useful cleanup.

----------
keywords: +needs review
nosy: +eric.araujo, petri.lehtinen, tarek
stage:  -> patch review
versions:  -Python 2.6, Python 2.7, Python 3.1, Python 3.2

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12721>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to