Mark Dickinson <dicki...@gmail.com> added the comment:

The new patch looks fine;  I'd still like to have the more explicit reference 
counting in range_hash (see replies on Rietveld).

A few more things:

- The patch needs a Misc/NEWS entry before committing;  it probably deserves a 
line in Doc/whatsnew/3.3.rst, too.

- The doc update should have a ".. versionchanged:: 3.3" note.

- Maybe the range_compare function could be renamed to something that makes it 
clearer it's just doing an equality comparison rather than a generalized 
comparison.  'range_equality_check'?  Or just 'range_equal' or 'range_equality'?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13201>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to