Petri Lehtinen <pe...@digip.org> added the comment: Hi!
I'd like to have this committed to be able to fix #13349. So here's a review. - In Doc/c-api/unicode.rst, the two "versionchanged:: 3.3" directives can be merged - In tests, I'd use 'abcde' rather than 'xxxxx' to make sure that correct characters are copied to the output (hope you understand what I mean) - No test checks that width and precision work on characters rather than bytes - The changes to unicodeobject.c don't apply on top of current default branch. ---------- keywords: +needs review stage: -> patch review versions: +Python 3.3 -Python 3.2 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7330> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com